Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #33364 and more trouble related to profressions with flashlight #33366

Merged

Conversation

pierredavidbelanger
Copy link
Contributor

@pierredavidbelanger pierredavidbelanger commented Aug 19, 2019

Summary

SUMMARY: Bugfixes "Fix professions with flashlights"

Purpose of change

fix #33364 (as an alternative to #33365)

Describe the solution

Added a new collection item_group called charged_flashlight with 100% charge, and modified all professions with flashlight item (security, survivalist, mall_cop, jr_survivalist) to use this new group.

Describe alternatives you've considered

I do not really know what I am doing :)

@RedShakespeare
Copy link
Contributor

Better idea indeed :)

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Aug 19, 2019
@ZhilkinSerg ZhilkinSerg merged commit 2970983 into CleverRaven:master Aug 20, 2019
misterprimus pushed a commit to misterprimus/Cataclysm-DDA that referenced this pull request Sep 21, 2019
…lashlight (CleverRaven#33366)

* fix CleverRaven#33364 and more trouble related to profressions with flashlight

* oups, forgot to run style-json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mall Security profession starts with flashlight, incompatible battery
3 participants